Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump loofah to 2.2.3 #73

Closed
wants to merge 1 commit into from
Closed

Conversation

jiahuang
Copy link

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

va-bot pushed a commit to department-of-veterans-affairs/caseflow that referenced this pull request Oct 31, 2018
ruby advisory fails on

```
Name: loofah
Version: 2.2.2
Advisory: CVE-2018-16468
Criticality: Unknown
URL: flavorjones/loofah#154
Title: Loofah XSS Vulnerability
Solution: upgrade to >= 2.2.3
```

Once rails/rails-html-sanitizer#73 is merged, we can remove this exception.
@matthewd
Copy link
Member

Thanks, but we prefer not to bump our dependencies just to force upgrades of other libraries. This change is not needed for applications to begin using the new updated version.

@jrochkind
Copy link

For those who get here, in case it wasn't clear, here's all you need to do to update to non-vulnerable dependency in your rails app:

$ bundle update loofah
# (or `bundle update loofah --conservative` if you don't want to update things loofah depends on also, like nokogiri, but really just go ahead and update nokogiri too)
$ git commit Gemfile.lock

You don't need to "wait for Rails to fix it", it's already fixed in loofah, you just need to update loofah.

Even if rails or rails-html-sanitizer had a new release with tighter loofah version restrictions -- you'd have to take the action to update your dependencies anyway, so it wouldn't give you much. Just update your loofah dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants